06 Feb, 2013
4 commits
-
If a milestone is created via API but no title given then status code 400 (Bad request) is returned instead of 404. A small helper method handles the errors collection of a milestone.
-
Creating a comment to an existing merge request via API without providing a note returns a status code 400 now, suggesting a bad request. The reason for this is the resource itself (MR) exists but the required property is not set.
-
Using the API library to create or update a merge request at the moment a 404 error is returned. This is fine when the merge request in question does not exist, but does not provide good information that for example a required attribute is missing. A status code of 400 (Bad request) is returned when creating or updating a merge request when either `source_branch` or `target_branch` is missing. A status code of 409 is returned when `source_branch` and `target_branch` are the same. Tests are added for these cases.
01 Feb, 2013
2 commits
-
The attempt to revoke project access for a user that was not member of the project results in a 500 Internal Server error where it actually should result in a 200 OK since after the operation, the user is not member of the project. This turns the operation into an idempotent call that can be repeated with no ill effects. Updated the spec and changed the code accordingly. However, the result differs slightly, as we can't return the users project access level if the user was not member. I'm not aware if anybody relies on the result of this call. Fixes #2832
-
In case we rescue from a fatal error, we want the error and the backtrace to the error logged, so we can debug later on. This change injects the configured logger from the rails app to the grape API and logs error as well as backtrace in a rails-like fashion.
29 Jan, 2013
2 commits
-
This rescues all errors and returns a proper JSON response. Fixes #2833.
28 Jan, 2013
7 commits
27 Jan, 2013
1 commit
-
Updates web hooks to process via queue
26 Jan, 2013
1 commit
25 Jan, 2013
4 commits
-
A new queue of "project_web_hook" is used to process web hooks asynchronously, allowing each to succeed/fail (and be retried) independently. (Basically, project web hooks now process the same as system hooks.)
24 Jan, 2013
3 commits
23 Jan, 2013
3 commits
-
Remove relative_url_root from path. Fixes #2602
-
Files and Commits render a 404 when running with relative_url_root.
22 Jan, 2013
2 commits
19 Jan, 2013
5 commits
18 Jan, 2013
1 commit
17 Jan, 2013
5 commits
