Software Publico / Gitlab

11 Jun, 2013

1 commit

993af5d0 cattr_accessor is not threadsafe! Browse File »

Dmitriy Zaporozhets
2013-06-11 18:15:18 +0300

14 May, 2013

1 commit

634cbd71 Refactor API classes. So api classes like Gitlab::Issues become API::Issues Browse File »

Dmitriy Zaporozhets
2013-05-14 15:33:31 +0300

28 Mar, 2013

1 commit

63e6f055 Fix notify specs. Fix merge request close via api Browse File »

Dmitriy Zaporozhets
2013-03-28 13:24:01 +0200

07 Mar, 2013

1 commit

3374027e Merge branch 'master' into fixes/api, code clean up and tests fixed ... Browse File »
```
Conflicts:
	doc/api/projects.md
	spec/requests/api/projects_spec.rb
```
Sebastian Ziebell
2013-03-07 14:51:56 +0100

05 Mar, 2013

1 commit

b5ef6d22 API: refactored and simplified error handling in merge requests API Browse File »

Sebastian Ziebell
2013-03-05 23:43:05 +0100

27 Feb, 2013

2 commits

7499f650 API: extracted helper method to validate required parameters, code clean up ... Browse File »

Added a helper method to check if required parameters are given in an API call. Can be used
to return a `400 Bad Request` return code if a required attribute is missing.
Code clean up and fixed tests.

2013-02-27 17:50:30 +0100

3b3add35 API: merge request documentation updated, added return codes to functions ... Browse File »

The API documentation of merge requests contains info to status codes for all functions.
Required arguments are now checked in the merge requests API functions and a `400 Bad Request` error is
returned if they are not given.

2013-02-27 15:07:42 +0100

20 Feb, 2013

1 commit

eefb27f5 Merge branch 'master' into fixes/api ... Browse File »
```
Conflicts:
	spec/requests/api/projects_spec.rb
```
Sebastian Ziebell
2013-02-20 12:43:32 +0100

18 Feb, 2013

1 commit

29f70acc Merge Request uses StateMachine now Browse File »

Andrew8xx8
2013-02-18 14:43:50 +0400

13 Feb, 2013

1 commit

6fc3263e API: extracted helper method to provide 400 bad request error with description ... Browse File »

Extracted a method for 400 error (Bad request) and adjusted code accordingly. The name of
the missing attribute is used to show which one was missing from the request. It is used to
give an appropriate message in the json response.

2013-02-13 15:48:52 +0100

06 Feb, 2013

3 commits

f978a71f Creating MR comment without a note returns status code 400 (Bad request) ... Browse File »

Creating a comment to an existing merge request via API without providing a note
returns a status code 400 now, suggesting a bad request. The reason for this
is the resource itself (MR) exists but the required property is not set.

2013-02-06 17:02:30 +0100

3f4e215c Extracted helper method to avoid code duplication Browse File »

Sebastian Ziebell
2013-02-06 17:02:30 +0100

413952ff Creating or updating a MR returns more informative status codes. ... Browse File »

Using the API library to create or update a merge request at the moment a 404 error is returned.
This is fine when the merge request in question does not exist, but does not provide good
information that for example a required attribute is missing.
A status code of 400 (Bad request) is returned when creating or updating a merge request
when either `source_branch` or `target_branch` is missing. A status code of 409 is returned
when `source_branch` and `target_branch` are the same. Tests are added for these cases.

2013-02-06 16:57:00 +0100