Software Publico / Gitlab

13 Feb, 2013

1 commit

6fc3263e API: extracted helper method to provide 400 bad request error with description ... Browse File »

Extracted a method for 400 error (Bad request) and adjusted code accordingly. The name of
the missing attribute is used to show which one was missing from the request. It is used to
give an appropriate message in the json response.

2013-02-13 15:48:52 +0100

06 Feb, 2013

3 commits

f978a71f Creating MR comment without a note returns status code 400 (Bad request) ... Browse File »

Creating a comment to an existing merge request via API without providing a note
returns a status code 400 now, suggesting a bad request. The reason for this
is the resource itself (MR) exists but the required property is not set.

2013-02-06 17:02:30 +0100

3f4e215c Extracted helper method to avoid code duplication Browse File »

Sebastian Ziebell
2013-02-06 17:02:30 +0100

413952ff Creating or updating a MR returns more informative status codes. ... Browse File »

Using the API library to create or update a merge request at the moment a 404 error is returned.
This is fine when the merge request in question does not exist, but does not provide good
information that for example a required attribute is missing.
A status code of 400 (Bad request) is returned when creating or updating a merge request
when either `source_branch` or `target_branch` is missing. A status code of 409 is returned
when `source_branch` and `target_branch` are the same. Tests are added for these cases.

2013-02-06 16:57:00 +0100