16 May, 2016
5 commits
-
(cherry picked from commit 18589b83f421fd4b3f6680125e336b1e4cd64dc5)
-
(cherry picked from commit 06d7abf4db251643c6a1bf644dc667190c65320a)
15 May, 2016
1 commit
14 May, 2016
5 commits
-
This method fits bteer into a helper since it is formatting data for the view.
-
It is no longer necessary given the rendering structure at BoxesHelper.
-
This removes some HTML generation from the model class.
13 May, 2016
14 commits
-
admin_notifications: ActiveRecord::Base to ApplicationRecord See merge request !909
-
Remove ProfileMembersHeadlinesBlock#content This method was in violation of MVC principles and its logic is now handled by the BoxesHelper. Minor adaptations to the view and a rename were required in order to meet BoxesHelper expectations. See merge request !908
-
Remove TourBlock#content This method was in violation of MVC principles and its logic is now handled by the BoxesHelper. See merge request !907
-
Remove InterestsBlock#content method This removes html generation from the class improving MVC responsability separation. It required the creation of a new method, interests, and view move/rename. See merge request !916
-
Refactor breadcrumbs plugin The `ContentBreadcrumbsBlock` class HTML generation have been refactored (thanks @joenio) in terms of view and helper, improving MVC compliance but still missed the Controller coupling with the view and helper through the dependency for `params` variable. I'm still not 100% sure if `params` is accessible from views. Some more feedback and review on it would be welcome. Finally the unit tests have been fixed accordingly to the refactor. Travis build: https://travis-ci.org/rafamanzo/noosfero/builds/128041637 See merge request !898
12 May, 2016
2 commits
-
This removes html generation from the class improving MVC responsability separation. It required the creation of a new method, interests, and view move/rename.
10 May, 2016
13 commits
-
expose statistics block atrributes in api expose statistics block atrributes in api See merge request !902
-
comment_paragraph: add discussion content type See merge request !903
-
This method was in violation of MVC principles and its logic is now handled by the BoxesHelper. Minor adaptations to the view and a rename were required in order to meet BoxesHelper expectations.
-
This method was in violation of MVC principles and its logic is now handled by the BoxesHelper.
-
This provides a cleaner view than html.erb.
-
After the refactor removing HTML generation from the Block subclass, the tests were outdated. The tests related to methods moved to the helper have been placed on its own test file and adapted accordingly since the code has changed slightly, but the assertions remained untouched (thus the refactor is correct). Finally block tests related to the view have been moved into a new view test suite.
