Merge Request #2
← To merge requests
From
gitlab_integration
into
master
Gitlab integration
Quick changes beacuse:
- New heder name for user data.
- Publish gem.
Commits (2)
Showing
4 changed files
Show diff stats
Rakefile
1 | require 'bundler' | 1 | require 'bundler' |
2 | Bundler::GemHelper.install_tasks | 2 | Bundler::GemHelper.install_tasks |
3 | 3 | ||
4 | -require 'rspec/core/rake_test' | ||
5 | -desc "Run specs." | ||
6 | -RSpec::Core::RakeTask.new(:spec) | ||
7 | 4 | ||
8 | task :default => :spec | 5 | task :default => :spec |
9 | task :test => :spec | 6 | task :test => :spec |
lib/omniauth-remote-user/version.rb
lib/omniauth/strategies/remote_user.rb
@@ -70,7 +70,7 @@ module OmniAuth | @@ -70,7 +70,7 @@ module OmniAuth | ||
70 | end | 70 | end |
71 | 71 | ||
72 | info do | 72 | info do |
73 | - user_data = request.env['HTTP_REMOTE_USER_DATA'] | 73 | + user_data = request.env['X_REMOTE_USER_DATA'] |
1 |
|
||
74 | if user_data | 74 | if user_data |
75 | data = JSON.parse(user_data) | 75 | data = JSON.parse(user_data) |
76 | data['nickname'] = uid | 76 | data['nickname'] = uid |
omniauth-remote-user.gemspec
@@ -7,7 +7,7 @@ Gem::Specification.new do |gem| | @@ -7,7 +7,7 @@ Gem::Specification.new do |gem| | ||
7 | gem.description = 'Authentication with Remote-User HTTP header for Omniauth.' | 7 | gem.description = 'Authentication with Remote-User HTTP header for Omniauth.' |
8 | gem.summary = 'Authentication with HTTP Remote User' | 8 | gem.summary = 'Authentication with HTTP Remote User' |
9 | gem.email = ['kanashiro.duarte@gmail.com', 'thiagitosouza@gmail.com', 'rodrigosiqueiramelo@gmail.com','macartur.sc@gmail.com','terceiro@softwarelivre.org'] | 9 | gem.email = ['kanashiro.duarte@gmail.com', 'thiagitosouza@gmail.com', 'rodrigosiqueiramelo@gmail.com','macartur.sc@gmail.com','terceiro@softwarelivre.org'] |
10 | - gem.homepage = 'http://beta.softwarepublico.gov.br/gitlab/softwarepublico/omiauth-remote-user' | 10 | + gem.homepage = 'http://beta.softwarepublico.gov.br/gitlab/softwarepublico/omniauth-remote-user' |
11 | gem.authors = ['Lucas Kanashiro', 'Thiago Ribeiro', 'Rodrigo Siqueira','Macartur Sousa', 'Antonio Terceiro'] | 11 | gem.authors = ['Lucas Kanashiro', 'Thiago Ribeiro', 'Rodrigo Siqueira','Macartur Sousa', 'Antonio Terceiro'] |
12 | gem.require_paths = %w(lib) | 12 | gem.require_paths = %w(lib) |
13 | gem.files = `git ls-files -z`.split("\x0").reject {|f| f.start_with?('spec/')} | 13 | gem.files = `git ls-files -z`.split("\x0").reject {|f| f.start_with?('spec/')} |
-
make sure to tag the exact version you publish to rubygems
-
Ok, that's really a good pratice. Done.
-
@thiagitosouza feel free to send a MR! ;)
started a discussion
on the diff
lib/omniauth/strategies/remote_user.rb
70 | 70 | end |
71 | 71 | |
72 | 72 | info do |
73 | - user_data = request.env['HTTP_REMOTE_USER_DATA'] | |
73 | + user_data = request.env['X_REMOTE_USER_DATA'] | |
1 |
|