Download as
Browse Code »

Commit 20ac104d8a2654774a475c90f95f09dce1a86e55

Authored by Daniela Feitosa
1 parent 0f1bc65a
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

ActionItem1111: in postgres, when search for blank there was a crash 

   * Adding .to_i before searching on database
Showing 2 changed files with 13 additions and 1 deletions   Show diff stats
app/models/approve_article.rb
  Diff comments   View file @20ac104
@@ -44,7 +44,7 @@ class ApproveArticle < Task @@ -44,7 +44,7 @@ class ApproveArticle < Task
44 end 44 end
45 45
46 def article_parent 46 def article_parent
47 - Article.find_by_id article_parent_id 47 + Article.find_by_id article_parent_id.to_i
48 end 48 end
49 49
50 def article_parent= value 50 def article_parent= value
test/functional/tasks_controller_test.rb
  Diff comments   View file @20ac104
@@ -191,4 +191,16 @@ class TasksControllerTest < Test::Unit::TestCase @@ -191,4 +191,16 @@ class TasksControllerTest < Test::Unit::TestCase
191 assert_equal true, PublishedArticle.find(:first).highlighted 191 assert_equal true, PublishedArticle.find(:first).highlighted
192 end 192 end
193 193
  194 + should 'create published article after choosing root folder on approve article task' do
  195 + PublishedArticle.destroy_all
  196 + c = Community.create!(:name => 'test comm', :moderated_articles => false)
  197 + @controller.stubs(:profile).returns(c)
  198 + c.affiliate(profile, Profile::Roles.all_roles(profile.environment.id))
  199 + article = profile.articles.create!(:name => 'something interesting', :body => 'ruby on rails')
  200 + t = ApproveArticle.create!(:name => 'test name', :article => article, :target => c, :requestor => profile)
  201 +
  202 + post :close, :decision => 'finish', :id => t.id, :task => { :name => 'new_name', :article_parent_id => ""}
  203 + assert_not_nil PublishedArticle.find(:first)
  204 + end
  205 +
194 end 206 end