Download as
Browse Code »

Commit 3cb47369e3969ca6e5d88fa14c34af81c99b3f05

Authored by Larissa Reis
1 parent bedac4e4
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

Improves error message for forms in task page

Showing 1 changed file with 15 additions and 1 deletions   Show diff stats
plugins/custom_forms/lib/custom_forms_plugin/membership_survey.rb
  Diff comments   View file @3cb4736
... ... @@ -13,7 +13,21 @@ class CustomFormsPlugin::MembershipSurvey < Task
13 13  
14 14 answers = build_answers(submission, form)
15 15 s = CustomFormsPlugin::Submission.create!(:form => form, :profile => target)
16   - answers.map {|answer| answer.submission = s; answer.save!}
  16 + s.answers.push(*answers)
  17 +
  18 + failed_answers = answers.select {|answer| !answer.valid? }
  19 + if failed_answers.empty?
  20 + s.save!
  21 + else
  22 + s.errors.clear
  23 + answers.each do |answer|
  24 + answer.valid?
  25 + answer.errors.each do |attribute, msg|
  26 + s.errors.add(answer.field.id.to_s.to_sym, msg)
  27 + end
  28 + end
  29 + raise ActiveRecord::RecordInvalid, s
  30 + end
17 31 end
18 32  
19 33 def title
... ...