Improves error message for forms in task page

Larissa Reis
1 parent bedac4e4
Showing 1 changed file with 15 additions and 1 deletions Show diff stats
plugins/custom_forms/lib/custom_forms_plugin/membership_survey.rb
@@ -13,7 +13,21 @@ class CustomFormsPlugin::MembershipSurvey &lt; Task
     answers = build_answers(submission, form)
     s = CustomFormsPlugin::Submission.create!(:form => form, :profile => target)
-    answers.map {|answer| answer.submission = s; answer.save!}
+    s.answers.push(*answers)
+
+    failed_answers = answers.select {|answer| !answer.valid? }
+    if failed_answers.empty?
+      s.save!
+    else
+      s.errors.clear
+      answers.each do |answer|
+        answer.valid?
+        answer.errors.each do |attribute, msg|
+          s.errors.add(answer.field.id.to_s.to_sym, msg)
+        end
+      end
+      raise ActiveRecord::RecordInvalid, s
+    end
   end
   def title
	@@ -13,7 +13,21 @@ class CustomFormsPlugin::MembershipSurvey < Task		@@ -13,7 +13,21 @@ class CustomFormsPlugin::MembershipSurvey < Task
13		13
14	answers = build_answers(submission, form)	14	answers = build_answers(submission, form)
15	s = CustomFormsPlugin::Submission.create!(:form => form, :profile => target)	15	s = CustomFormsPlugin::Submission.create!(:form => form, :profile => target)
16	- answers.map {\|answer\| answer.submission = s; answer.save!}	16	+ s.answers.push(*answers)
		17	+
		18	+ failed_answers = answers.select {\|answer\| !answer.valid? }
		19	+ if failed_answers.empty?
		20	+ s.save!
		21	+ else
		22	+ s.errors.clear
		23	+ answers.each do \|answer\|
		24	+ answer.valid?
		25	+ answer.errors.each do \|attribute, msg\|
		26	+ s.errors.add(answer.field.id.to_s.to_sym, msg)
		27	+ end
		28	+ end
		29	+ raise ActiveRecord::RecordInvalid, s
		30	+ end
17	end	31	end
18		32
19	def title	33	def title