Download as
Browse Code »

Commit 73479a2c7c52e323c027dc83ad06f157d221ca17

Authored by Rodrigo Souto
1 parent cd32f252
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

application_helper/rolename: improve performance retrieval and readability

Showing 1 changed file with 4 additions and 1 deletions   Show diff stats
app/helpers/application_helper.rb
  Diff comments   View file @73479a2
... ... @@ -727,7 +727,10 @@ module ApplicationHelper
727 727 end
728 728  
729 729 def rolename_for(profile, resource)
730   - roles = profile.role_assignments.select{ |a| a.resource_id == resource.id }.sort_by{ |s| s.role_id }.map(&:role)
  730 + roles = profile.role_assignments.
  731 + where(:resource_id => resource.id).
  732 + sort_by{ |role_assignment| role_assignment.role_id }.
  733 + map(&:role)
731 734 names = []
732 735 roles.each do |role|
733 736 names << content_tag('span', role.name, :style => "color: #{role_color(role, resource.environment.id)}")
... ...