16 Apr, 2016

1 commit

29 Jan, 2016

1 commit

  • 5ee25d55   Replace url helpers by the path ones ... Browse File » 
    This is expected to improve compatibility with reverse-proxies.

Still, for full compatibility, regarding redirections, we still may
need to set the default url options with the proxy host.

Signed-off-by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Heitor
     

20 Jan, 2016

2 commits

  • 20ed82ce   Fix Metric Configuration controllers unit tests Browse File »
    Daniel
     
  • 82bc8ca4   Update MetricConfiguration controllers' tests ... Browse File » 
    - Fix usage of MetricConfiguration models converted directly to hashes
as parameters. It didn't reflect how they are actually sent and omitted
some necessary parameters like metric_collector_name and
metric_name/metric_code, which are now passed.
- Fix KalibroConfigurations not being searched by the controller
methods. We must be sure they exist, and fail with a 404 if they don't
instead of failing only in one of the ownership testing methods.
- Update the expectations for cache cleaning to include both Hotspot and
Tree MetricConfigurations

Signed off by: Daniel Miranda <danielkza2@gmail.com>
    Heitor
     

26 Oct, 2015

1 commit

21 May, 2015

3 commits

27 Apr, 2015

1 commit

  • e390e540   Correct error handling for resource finding in controllers ... Browse File » 
    Error handling for finding resources in controllers used a find_resource
method. It was broken and was letting code pass-through after errors. In
addition, cases for find methods for things other than simple IDs
weren't handled.

Replace it with an error handler in ApplicationController capturing
RecordNotFound exceptions and returning the appropriate error pages (or
JSON).

Also, fix usages of find that should throw errors (using ActiveRecord
methods ending with !) but didn't.

Correspondly, fix all the tests that mocked the find_resource method,
and correct expectations where needed.

Signed-off-by: Daniel Miranda <danielkza2@gmail.com>
    Diego Camarinha
     

17 Apr, 2015

1 commit

12 Feb, 2015

11 commits

10 Dec, 2014

1 commit

07 Aug, 2014

1 commit

11 Jun, 2014

2 commits

05 Jun, 2014

1 commit

  • d576da37   Convert specs to RSpec 2.99.0 syntax with Transpec ... Browse File » 
    This conversion is done by Transpec 2.2.1 with the following command:
    transpec

* 258 conversions
    from: it { should ... }
      to: it { is_expected.to ... }

* 82 conversions
    from: obj.should
      to: expect(obj).to

* 16 conversions
    from: describe 'some model' { }
      to: describe 'some model', :type => :model { }

* 12 conversions
    from: describe 'some controller' { }
      to: describe 'some controller', :type => :controller { }

* 11 conversions
    from: describe 'some routing' { }
      to: describe 'some routing', :type => :routing { }

* 8 conversions
    from: describe 'some helper' { }
      to: describe 'some helper', :type => :helper { }

* 7 conversions
    from: be_false
      to: be_falsey

* 6 conversions
    from: be_true
      to: be_truthy

* 6 conversions
    from: it { should_not ... }
      to: it { is_expected.not_to ... }

* 4 conversions
    from: obj.should_not
      to: expect(obj).not_to

For more details: https://github.com/yujinakayama/transpec#supported-conversions

Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
    Renan Fichberg
     

26 Feb, 2014

10 commits