Added column to backtrace for JS errors

Nathan Broadbent
1 parent 0c05052f
Showing 2 changed files with 4 additions and 1 deletions Show diff stats
app/models/backtrace_line.rb
app/views/notices/_backtrace_line.html.haml
@@ -4,6 +4,7 @@ class BacktraceLine
   GEMS_PATH   = %r{\[GEM_ROOT\]\/gems\/([^\/]+)}
  
   field :number, :type => Integer
+  field :column, :type => Integer
   field :file
   field :method
  
@@ -14,7 +15,7 @@ class BacktraceLine
   delegate :app, :to => :backtrace
  
   def to_s
-    "#{file}:#{number}"
+    "#{file}:#{number}" << (column.present? ? ":{column}" : "")
   end
  
   def in_app?
@@ -5,5 +5,7 @@
       %span.file>= line.file_name
       - if line.number.present?
         %span.number>= ":#{line.number}"
+      - if line.column.present?
+        %span.number>= ":#{line.column}"
     &rarr;
     %span.method= line.method
...	...	@@ -4,6 +4,7 @@ class BacktraceLine
4	4	GEMS_PATH = %r{\[GEM_ROOT\]\/gems\/([^\/]+)}
5	5
6	6	field :number, :type => Integer
	7	+ field :column, :type => Integer
7	8	field :file
8	9	field :method
9	10
...	...	@@ -14,7 +15,7 @@ class BacktraceLine
14	15	delegate :app, :to => :backtrace
15	16
16	17	def to_s
17		- "#{file}:#{number}"
	18	+ "#{file}:#{number}" << (column.present? ? ":{column}" : "")
18	19	end
19	20
20	21	def in_app?
...	...
...	...	@@ -5,5 +5,7 @@
5	5	%span.file>= line.file_name
6	6	- if line.number.present?
7	7	%span.number>= ":#{line.number}"
	8	+ - if line.column.present?
	9	+ %span.number>= ":#{line.column}"
8	10	→
9	11	%span.method= line.method
...	...