Commit 55b516633d4ed8f348dd9b70b111ec4efbfecd7c

Authored by Nathan Broadbent
1 parent 0c05052f
Exists in master and in 1 other branch production

Added column to backtrace for JS errors

app/models/backtrace_line.rb
@@ -4,6 +4,7 @@ class BacktraceLine @@ -4,6 +4,7 @@ class BacktraceLine
4 GEMS_PATH = %r{\[GEM_ROOT\]\/gems\/([^\/]+)} 4 GEMS_PATH = %r{\[GEM_ROOT\]\/gems\/([^\/]+)}
5 5
6 field :number, :type => Integer 6 field :number, :type => Integer
  7 + field :column, :type => Integer
7 field :file 8 field :file
8 field :method 9 field :method
9 10
@@ -14,7 +15,7 @@ class BacktraceLine @@ -14,7 +15,7 @@ class BacktraceLine
14 delegate :app, :to => :backtrace 15 delegate :app, :to => :backtrace
15 16
16 def to_s 17 def to_s
17 - "#{file}:#{number}" 18 + "#{file}:#{number}" << (column.present? ? ":{column}" : "")
18 end 19 end
19 20
20 def in_app? 21 def in_app?
app/views/notices/_backtrace_line.html.haml
@@ -5,5 +5,7 @@ @@ -5,5 +5,7 @@
5 %span.file>= line.file_name 5 %span.file>= line.file_name
6 - if line.number.present? 6 - if line.number.present?
7 %span.number>= ":#{line.number}" 7 %span.number>= ":#{line.number}"
  8 + - if line.column.present?
  9 + %span.number>= ":#{line.column}"
8 &rarr; 10 &rarr;
9 %span.method= line.method 11 %span.method= line.method