Rubocop: method definitions always use ()

Laust Rud Jacobsen
1 parent a21ce09a
Showing 3 changed files with 3 additions and 9 deletions Show diff stats
.rubocop_todo.yml
app/controllers/apps_controller.rb
app/models/notification_services/gtalk_service.rb
@@ -318,12 +318,6 @@ Style/LeadingCommentSpace:
     - 'spec/models/notification_service/hoiio_service_spec.rb'
     - 'spec/models/notification_service/pushover_service_spec.rb'
  
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/MethodDefParentheses:
-  Enabled: false
-
 # Offense count: 7
 # Cop supports --auto-correct.
 Style/MultilineBlockLayout:
@@ -103,7 +103,7 @@ class AppsController &lt; ApplicationController
       end
     end
  
-    def plug_params app
+    def plug_params(app)
       app.watchers.build if app.watchers.none?
       app.issue_tracker ||= IssueTracker.new
       app.notification_service = NotificationService.new unless app.notification_service_configured?
@@ -59,13 +59,13 @@ class NotificationServices::GtalkService &lt; NotificationService
  
   private
  
-  def send_to_users client, message
+  def send_to_users(client, message)
     user_id.tr(' ', ",").tr(';', ",").split(",").map(&:strip).reject(&:empty?).each do |user|
       client.send(Jabber::Message.new(user, message))
     end
   end
  
-  def send_to_muc client, message
+  def send_to_muc(client, message)
     #TODO: set this so that it can send to multiple rooms like users, nb multiple room joins in one send fail randomly so leave as one room for the moment 
     muc = Jabber::MUC::SimpleMUCClient.new(client)
     muc.join(room_id + "/errbit")
...	...	@@ -318,12 +318,6 @@ Style/LeadingCommentSpace:
318	318	- 'spec/models/notification_service/hoiio_service_spec.rb'
319	319	- 'spec/models/notification_service/pushover_service_spec.rb'
320	320
321		-# Offense count: 3
322		-# Cop supports --auto-correct.
323		-# Configuration parameters: EnforcedStyle, SupportedStyles.
324		-Style/MethodDefParentheses:
325		- Enabled: false
326		-
327	321	# Offense count: 7
328	322	# Cop supports --auto-correct.
329	323	Style/MultilineBlockLayout:
...	...
...	...	@@ -103,7 +103,7 @@ class AppsController < ApplicationController
103	103	end
104	104	end
105	105
106		- def plug_params app
	106	+ def plug_params(app)
107	107	app.watchers.build if app.watchers.none?
108	108	app.issue_tracker \|\|= IssueTracker.new
109	109	app.notification_service = NotificationService.new unless app.notification_service_configured?
...	...
...	...	@@ -59,13 +59,13 @@ class NotificationServices::GtalkService < NotificationService
59	59
60	60	private
61	61
62		- def send_to_users client, message
	62	+ def send_to_users(client, message)
63	63	user_id.tr(' ', ",").tr(';', ",").split(",").map(&:strip).reject(&:empty?).each do \|user\|
64	64	client.send(Jabber::Message.new(user, message))
65	65	end
66	66	end
67	67
68		- def send_to_muc client, message
	68	+ def send_to_muc(client, message)
69	69	#TODO: set this so that it can send to multiple rooms like users, nb multiple room joins in one send fail randomly so leave as one room for the moment
70	70	muc = Jabber::MUC::SimpleMUCClient.new(client)
71	71	muc.join(room_id + "/errbit")
...	...