NoosferoGov / errbit

12 Oct, 2015

35 commits

294d63ad Merge pull request #964 from rud/chore/fix-low-hanging-rubocop-issues ... Browse Code »
```
Fix some low hanging rubocop issues
```
Stephen Crosby
2015-10-12 13:40:13 -0700
3fe954ae Rubocop: use the auto-wrapping Array() method Browse Code »

Laust Rud Jacobsen
2015-10-12 22:19:49 +0200
57d22238 Rubocop: string encoding simplify Browse Code »

Laust Rud Jacobsen
2015-10-12 22:07:08 +0200
ba9c1cb2 Rubocop: use word-arrays Browse Code »

Laust Rud Jacobsen
2015-10-12 22:07:08 +0200
4bdcb547 Rubocop: use "when then" instead "when;" Browse Code »

Laust Rud Jacobsen
2015-10-12 22:07:08 +0200
d272b2e2 Rubocop: remove redundant self. calls Browse Code »

Laust Rud Jacobsen
2015-10-12 22:07:07 +0200
5424a5c8 Rubocop: a fail without an exception class is a RuntimeError Browse Code »

Laust Rud Jacobsen
2015-10-12 22:07:07 +0200
c733db0c Rubocop: fix unnecessary parallel assignment Browse Code »

Laust Rud Jacobsen
2015-10-12 22:07:07 +0200
4b670105 Rubocop: fix use of "if !" Browse Code »

Laust Rud Jacobsen
2015-10-12 22:07:07 +0200
8cc1085f Rubocop: method definitions always use () Browse Code »

Laust Rud Jacobsen
2015-10-12 22:07:07 +0200
a21ce09a Rubocop: fix all uses of !! - replace with thing.present? Browse Code »

Laust Rud Jacobsen
2015-10-12 22:07:07 +0200
c8514607 Rubocop: use Hash.key? instead of Hash.has_key? (deprecated) Browse Code »

Laust Rud Jacobsen
2015-10-12 21:48:34 +0200
312b43fe Rubocop: remove unnecessary method call parentheses Browse Code »

Laust Rud Jacobsen
2015-10-12 21:41:54 +0200
f2c11950 Rubocop: disable .find_by rule, mongoid is different Browse Code »

Laust Rud Jacobsen
2015-10-12 21:41:54 +0200
126757c5 Rubocop: always use Time.zone.now, this fixes interesting time inconsistencies Browse Code »

Laust Rud Jacobsen
2015-10-12 21:41:54 +0200
b76bf20a Rubocop: perfer .tr over .gsub when just replacing chars Browse Code »

Laust Rud Jacobsen
2015-10-12 21:41:54 +0200
c30adbfc Rubocop: fix uses of "and" ... Browse Code »
```
Notice the return value of a before_action is ignored, so we can safely remove that code.
```
Laust Rud Jacobsen
2015-10-12 21:41:54 +0200
f1f39cdc Rubocop: consistently indenting private/protected with method defs ... Browse Code »
```
That's what the majority of the codebase is using, so following that
```
Laust Rud Jacobsen
2015-10-12 21:41:54 +0200
47b11978 Rubocop: autofix alias -> use alias_method instead Browse Code »

Laust Rud Jacobsen
2015-10-12 21:37:54 +0200
25296125 Rubocop: Rails 4: use *_before_action instead of *_before_filter Browse Code »

Laust Rud Jacobsen
2015-10-12 21:37:54 +0200
b4c2a337 Rubocop: minor performance change: use Array.sample over Array.shuffle.first Browse Code »

Laust Rud Jacobsen
2015-10-12 21:37:54 +0200
f6bea424 Merge pull request #963 from rud/chore/install-rubocop ... Browse Code »
```
Install rubocop - auto-validating syntax checking
```
Stephen Crosby
2015-10-12 08:41:24 -0700
8bab6910 Merge pull request #965 from rud/chore/rspec-random-order ... Browse Code »
```
RSpec: run in random order
```
Stephen Crosby
2015-10-12 08:37:47 -0700
fba9b79c Merge pull request #966 from stevecrozz/ruby-version-error ... Browse Code »
```
incompatible ruby version error
```
Stephen Crosby
2015-10-12 08:36:36 -0700
5e9ea72f CI: run rubocop in --lint mode to catch at least syntax errors Browse Code »

Laust Rud Jacobsen
2015-10-12 09:37:20 +0200
8b50d716 Rubocop: base config with Rails cops enabled Browse Code »

Laust Rud Jacobsen
2015-10-12 09:37:20 +0200
22eff788 Rubocop: fix silently swallowing exceptions, use Kernel.warn for output Browse Code »

Laust Rud Jacobsen
2015-10-12 09:37:20 +0200
4f9b40cc Rubocop: fix ambiguous regexp literal / division Browse Code »

Laust Rud Jacobsen
2015-10-12 09:37:20 +0200
00b8969c Rubocop: fix ambiguous splat operator ... Browse Code »
```
Fixes:
$ rubocop --lint --only AmbiguousOperator
```
Laust Rud Jacobsen
2015-10-12 09:37:20 +0200
262db103 Rubocop: manually fix shadowing of outer variable ... Browse Code »
```
Fixes:
$ rubocop --lint --only ShadowingOuterLocalVariable
```
Laust Rud Jacobsen
2015-10-12 09:37:20 +0200
af47f58d Rubocop: fix lint warnings: space before arguments to method call ... Browse Code »
```
Fixes:
$ rubocop --lint --only Lint/ParenthesesAsGroupedExpression
```
Laust Rud Jacobsen
2015-10-12 09:37:20 +0200
ac0691c0 Rubocop: manually fix useless assignments ... Browse Code »
```
Now this succeeds:
$ bundle exec rubocop --lint --only UselessAssignment
```
Laust Rud Jacobsen
2015-10-12 09:35:33 +0200
432e02fb Rubocop: manually fixing linter warnings: assignment in condition Browse Code »

Laust Rud Jacobsen
2015-10-12 09:35:33 +0200
739bb175 Rubocop: auto-fixing linter warnings ... Browse Code »
```
Run with "bundle exec rubocop --lint --auto-correct"
```
Laust Rud Jacobsen
2015-10-12 09:35:32 +0200
dd98263d RSpec: run in random order ... Browse Code »
```
Fix a single spec that destructively modified the `Errbit::Config` and ruined it for other tests coming after it.
```
Laust Rud Jacobsen
2015-10-12 09:29:04 +0200

11 Oct, 2015

2 commits

ddcf21ea incompatible ruby version error ... Browse Code »

Some users are reporting errors due to incompatible ruby versions. This
commit aims to provide users with a helpful error message so they can
more easily spot the issue.

2015-10-11 14:00:49 -0700

0c59c718 Add gem rubocop for development and test Browse Code »

Laust Rud Jacobsen
2015-10-11 12:56:02 +0200

07 Oct, 2015

1 commit

5639825e add upgrade beyond v0.4.0 notes Browse Code »

Stephen Crosby
2015-10-07 15:26:50 -0700

06 Oct, 2015

2 commits

c6c8ffbd Merge pull request #958 from appropriate/github-enterprise-login ... Browse Code »
```
GitHub enterprise login
```
Stephen Crosby
2015-10-06 13:20:28 -0700
1ac7afa9 Support GitHub Enterprise logins Browse Code »

Mike Dillon
2015-10-06 13:11:00 -0700