15 Nov, 2015
1 commit
04 Nov, 2015
3 commits
20 Oct, 2015
1 commit
-
This is a tough call, both the Rails style (with private/protected) methods indented one level under the keyword, and other places using the standard ruby don't modify identation for access level. I think this strikes a good balance while still being readable. s
12 Oct, 2015
3 commits
-
That's what the majority of the codebase is using, so following that
21 Mar, 2013
1 commit
-
<var> tags with blank values were ending up completely wrong in the resulting hash. This: (a user with a blank name) <var key="user"> <var key="id">123</var> <var key="name"/> </var> Gets parsed by hoptoad_notifier into this: { 'key' => 'user', 'var' => [{ 'key' => 'id', '__content__' => '123' },{ 'key' => 'name' }] } Which when passed through the "rekey" method, ended up like this: { 'user' => { 'id' => '123', 'key' => 'name' # bad and wrong } } Now, after these changes, it correctly comes through as: { 'user' => { 'id' => '123', 'name' => nil # much better! } }
06 Mar, 2013
1 commit
28 Jan, 2013
1 commit
11 Sep, 2012
1 commit
30 May, 2012
1 commit
28 May, 2012
2 commits
-
This allows us to know who took the action that caused the error, so we can follow up via email or phone if we need further information about the context.
01 Feb, 2012
1 commit
-
…key' for :klass field.)
26 Sep, 2011
1 commit
-
…les, fixed whitespace, upgraded RSpec to 2.6.0 Conflicts: app/helpers/errs_helper.rb app/mailers/mailer.rb app/models/notice.rb app/views/errs/_table.html.haml app/views/errs/show.html.haml app/views/notices/_summary.html.haml spec/models/issue_trackers/redmine_tracker_spec.rb spec/views/errs/show.html.haml_spec.rb
05 Sep, 2011
1 commit
-
concerns (e.g. fingerprint) from notice parsing concerns. This also makes it easier to support multiple versions of the Airbrake API.
