01 Dec, 2015
1 commit
24 Nov, 2015
1 commit
15 Nov, 2015
6 commits
-
By returning early the flow is hoped to be a bit clearer.
-
Based on https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals This handles a few of the cases.
-
Based on https://github.com/bbatsov/ruby-style-guide#single-line-blocks
04 Nov, 2015
9 commits
-
Humans tend to be easily confused by the unless/else construct, so banning it.
-
This allows code to be copy/pasted into the console for easy experimentation and spelunking.
31 Oct, 2015
4 commits
-
Sorry, this touches a lot of code.
23 Oct, 2015
1 commit
-
Rubocop: consistent access modifier indentation
20 Oct, 2015
2 commits
-
This reverts commit 644116d884df846f633ee0d213fab94138e80465.
-
This is a tough call, both the Rails style (with private/protected) methods indented one level under the keyword, and other places using the standard ruby don't modify identation for access level. I think this strikes a good balance while still being readable. s
15 Oct, 2015
5 commits
-
Still allowing for internal alignment across lines.
-
Tiny addition to overall consistency
14 Oct, 2015
2 commits
12 Oct, 2015
8 commits
-
Notice the return value of a before_action is ignored, so we can safely remove that code.
-
That's what the majority of the codebase is using, so following that
-
Now this succeeds: $ bundle exec rubocop --lint --only UselessAssignment
06 Oct, 2015
1 commit
